Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Provide an element to render in the annotation layer after a freetext has been edited (bug 1890535) #17914

Merged
merged 1 commit into from
Apr 18, 2024
Merged

[Editor] Provide an element to render in the annotation layer after a freetext has been edited (bug 1890535) #17914

merged 1 commit into from
Apr 18, 2024

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1e0805f998f79bb/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/ca850f0df7ffc6d/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/1e0805f998f79bb/output.txt

Total script time: 7.57 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/ca850f0df7ffc6d/output.txt

Total script time: 20.12 mins

  • Integration Tests: Passed

@calixteman calixteman requested a review from Snuffleupagus April 9, 2024 14:11
Snuffleupagus
Snuffleupagus requested changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes may affect general annotation-rendering, please run all tests.

web/pdf_page_view.js Outdated Show resolved Hide resolved
@Snuffleupagus
Copy link
Collaborator

Given the annotation-related changes here, this seems like something that shouldn't land just prior to a new release.

@timvandermeij This would be one more reason to make a new release ASAP, in my opinion.

@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/3bd6c63563cac84/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/103e134f687b0eb/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/103e134f687b0eb/output.txt

Total script time: 26.27 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 20
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/103e134f687b0eb/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/3bd6c63563cac84/output.txt

Total script time: 43.71 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 5

Image differences available at: http://54.193.163.58:8877/3bd6c63563cac84/reftest-analyzer.html#web=eq.log

Snuffleupagus
Snuffleupagus reviewed Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving a few comments based on a cursory look.

src/display/annotation_layer.js Outdated Show resolved Hide resolved
src/display/annotation_layer.js Outdated Show resolved Hide resolved
src/display/editor/editor.js Outdated Show resolved Hide resolved
Snuffleupagus
Snuffleupagus approved these changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, trusting that our test-coverage is sufficient to catch any edge-case problems; thank you!

src/display/annotation_layer.js Outdated Show resolved Hide resolved
@Snuffleupagus Snuffleupagus changed the title [Editor] Provide an element to render in the annotation layer after afreetext has been edited (bug 1890535) [Editor] Provide an element to render in the annotation layer after a freetext has been edited (bug 1890535) Apr 18, 2024
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/517dbb75d781bf9/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/99beb47b33ffcb4/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/517dbb75d781bf9/output.txt

Total script time: 7.45 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/99beb47b33ffcb4/output.txt

Total script time: 17.87 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 4866686 into mozilla:master Apr 18, 2024
9 checks passed
@calixteman calixteman deleted the freetext_edit branch April 18, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
annotations editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @moz-tools-bot @Snuffleupagus