-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api-minor] Update the minimum supported Safari version to 16.4 #17942
Conversation
This patch updates the minimum supported browsers as follows: - Safari 16.4, which was released on 2023-03-27; see https://developer.apple.com/documentation/safari-release-notes/safari-16_4-release-notes Nowadays we usually we try, where feasible and possible, to support browsers/environments that are about two years old. The reasons for limiting support to a slightly more recent Safari version include: - Safari has always been slower, compared to other browsers, at implementing e.g. new JavaScript features. - Trying to provide support for Safari is often difficult, and over the years we have seen *a lot* of bugs that are specific to Safari. - Safari is, and has been for many years, only listed as "mostly" supported in the FAQ. - This allows us to remove feature-testing, only relevant to Safari, from the main code-base. By limiting support to only "recent" browsers we reduce the risk of holding back improvements of the built-in Firefox PDF Viewer, and also (significantly) reduce the maintenance/support burden for the PDF.js core contributors. *Please note:* As always, the minimum supported browser version assumes that a `legacy`-build of the PDF.js library is being used; see https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#faq-support
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/9b49492b18796ce/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/13b07aed32e46e6/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/13b07aed32e46e6/output.txt Total script time: 26.45 mins
Image differences available at: http://54.241.84.105:8877/13b07aed32e46e6/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/9b49492b18796ce/output.txt Total script time: 43.07 mins
Image differences available at: http://54.193.163.58:8877/9b49492b18796ce/reftest-analyzer.html#web=eq.log |
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4023649e828e242/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/4023649e828e242/output.txt Total script time: 1.19 mins Published |
Thanks! |
@Snuffleupagus I just realized I forgot to ask: should we bump the minor version in |
Yes, that seems best so that we don't forget. |
This patch updates the minimum supported browsers as follows:
Nowadays we usually we try, where feasible and possible, to support browsers/environments that are about two years old. The reasons for limiting support to a slightly more recent Safari version include:
By limiting support to only "recent" browsers we reduce the risk of holding back improvements of the built-in Firefox PDF Viewer, and also (significantly) reduce the maintenance/support burden for the PDF.js core contributors.
Please note: As always, the minimum supported browser version assumes that a
legacy
-build of the PDF.js library is being used; see https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#faq-support