-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent XRef errors from breaking font loading (bug 1898802) #18166
Conversation
Note that the referenced file is trivially corrupt, since it contains *two* PDF documents placed in the same file which doesn't make sense (and isn't how a PDF document should be updated). However it's still a good idea to ensure that `loadFont` is able to handle errors when resolving References, since that allows us to invoke the existing fallback font handling.
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d607c451f02e5c8/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/3e1fecad99ecc2a/output.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/3e1fecad99ecc2a/output.txt Total script time: 27.79 mins
Image differences available at: http://54.241.84.105:8877/3e1fecad99ecc2a/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d607c451f02e5c8/output.txt Total script time: 42.46 mins
Image differences available at: http://54.193.163.58:8877/d607c451f02e5c8/reftest-analyzer.html#web=eq.log |
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/91396aa547a22bb/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7162d4eebcc424e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/7162d4eebcc424e/output.txt Total script time: 20.09 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/91396aa547a22bb/output.txt Total script time: 25.15 mins
|
Note that the referenced file is trivially corrupt, since it contains two PDF documents placed in the same file which doesn't make sense (and isn't how a PDF document should be updated).
However it's still a good idea to ensure that
loadFont
is able to handle errors when resolving References, since that allows us to invoke the existing fallback font handling.