Improve some old code in the src/display/api.js file
#18250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that we now check/validate all options properly this old code can be simplified.
… are disabled This helps reduce overall indentation in the method, thus leading to slightly less code. Also, remove an old comment referring to Chrome 15 since that's no longer relevant now.
The feature-testing on the worker-thread has been simplified in previous pull requests, which means that we can simplify this main-thread handler as well.
This avoids having to repeat the same code multiple times, since besides resolving the promise we also need to send the "configure" message to the worker-thread.
Snuffleupagus
force-pushed
the
api-misc-fixes
branch
from
caddf2e to
f3f88ee
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/3a4760351e18011/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/b4afeb2a40c7b10/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/3a4760351e18011/output.txt Total script time: 28.72 mins
Image differences available at: http://54.241.84.105:8877/3a4760351e18011/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/b4afeb2a40c7b10/output.txt Total script time: 43.94 mins
Image differences available at: http://54.193.163.58:8877/b4afeb2a40c7b10/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Jun 15, 2024
|
Thank you for improving this code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.