Improve the security policy #18323
Merged
Improve the security policy #18323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes two issues that have been found after commit 2beae7a landed, namely: - The security checkbox image is not rendering at https://github.com/mozilla/pdf.js/security/policy because the `SECURITY.md` file is apparently served differently there (because it does work as expected at https://github.com/mozilla/pdf.js/blob/master/.github/SECURITY.md), which causes the relative link not to work. We switch to an absolute link to fix the issue. - If a security policy is defined it turns out that GitHub automatically adds a row to the "New issue" page; see https://docs.github.com/en/code-security/getting-started/adding-a-security-policy-to-your-repository where it states "When someone creates an issue in your repository, they will see a link to your project's security policy". Since we now have two rows at https://github.com/mozilla/pdf.js/issues/new/choose about the security policy, we remove our own version in favor of the standard GitHub-provided one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes two issues that have been found after commit 2beae7a landed, namely:
SECURITY.mdfile is apparently served differently there (because it does work as expected at https://github.com/mozilla/pdf.js/blob/master/.github/SECURITY.md), which causes the relative link not to work. We switch to an absolute link to fix the issue.