Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-minor] Remove the deprecated renderTextLayer and updateTextLayer functions (PR 18104 follow-up) #18349

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

Snuffleupagus
Copy link
Collaborator

Please note: We probably want to create at least one more release before considering landing this.

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6c91c4e77be3555/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/7598ebb080a8171/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/7598ebb080a8171/output.txt

Total script time: 28.98 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 16

Image differences available at: http://54.241.84.105:8877/7598ebb080a8171/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/6c91c4e77be3555/output.txt

Total script time: 44.20 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 3
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/6c91c4e77be3555/reftest-analyzer.html#web=eq.log

@timvandermeij
Copy link
Contributor

I agree that it should be good to move forward with this now that 15b5808 has been part of two releases.

@Snuffleupagus Snuffleupagus marked this pull request as ready for review July 2, 2024 13:35
@timvandermeij timvandermeij merged commit ccad2f8 into mozilla:master Jul 2, 2024
9 checks passed
@timvandermeij
Copy link
Contributor

Thank you for cleaning this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants