Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the rendering of tiling pattern when the steps are lower than the tile dimensions (bug 1837738) #18798

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Fix the rendering of tiling pattern when the steps are lower than the tile dimensions (bug 1837738) #18798

merged 1 commit into from
Sep 26, 2024

Conversation

calixteman
Copy link
Contributor

It fixes #16038.

The idea is to create a pattern having the steps for dimensions and then draw the base tile and the different overlapping parts on it.

@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/3b479de42d900c7/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a4d03c60e36fbab/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/a4d03c60e36fbab/output.txt

Total script time: 30.98 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 26
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/a4d03c60e36fbab/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/3b479de42d900c7/output.txt

Total script time: 46.58 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 9

Image differences available at: http://54.193.163.58:8877/3b479de42d900c7/reftest-analyzer.html#web=eq.log

Snuffleupagus
Snuffleupagus approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, this was overall simpler than I expected; thank you.

test/pdfs/issue16038.pdf.link Outdated Show resolved Hide resolved
test/test_manifest.json Outdated Show resolved Hide resolved
@calixteman
Copy link
Contributor Author

r=me, this was overall simpler than I expected; thank you.

It was a bit more complex few days ago and I managed to simplify it.

@calixteman
Fix the rendering of tiling pattern when the steps are lower than the…
6d88f9f 
… tile dimensions (bug 1837738)

It fixes mozilla#16038.

The idea is to create a pattern having the steps for dimensions and then draw
the base tile and the different overlapping parts on it.
@calixteman calixteman force-pushed the pattern_negative_bbox branch from a586c38 to 6d88f9f Compare September 26, 2024 12:21
@calixteman calixteman merged commit 2ff8035 into mozilla:master Sep 26, 2024
8 checks passed
@calixteman
Copy link
Contributor Author

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/bdea70560381245/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/3f107a91f04f54b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/3f107a91f04f54b/output.txt

Total script time: 20.49 mins

  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/bdea70560381245/output.txt

Total script time: 27.21 mins

  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus mentioned this pull request Jan 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
tiling-type
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tiling pattern with negative bbox coordinates is not fully rendered
3 participants
@calixteman @moz-tools-bot @Snuffleupagus