Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mask-image duplication for the print/download buttons #18930

Conversation

Snuffleupagus
Copy link
Collaborator

With the recent re-factoring of the viewer CSS rules we now have some duplication of the mask-image definitions for the print/download buttons in the secondaryToolbar; note

pdf.js/web/viewer.css

Lines 1204 to 1210 in 17419de

#secondaryPrint::before {
mask-image: var(--toolbarButton-print-icon);
}
#secondaryDownload::before {
mask-image: var(--toolbarButton-download-icon);
}

With the recent re-factoring of the viewer CSS rules we now have some duplication of the `mask-image` definitions for the print/download buttons in the secondaryToolbar; note https://github.com/mozilla/pdf.js/blob/17419de15709892935ece25ffd6af105a7e6814d/web/viewer.css#L1204-L1210
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/71532da48b26e1b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/71532da48b26e1b/output.txt

Total script time: 0.98 mins

Published

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@Snuffleupagus Snuffleupagus merged commit d37e4b0 into mozilla:master Oct 21, 2024
8 checks passed
@Snuffleupagus Snuffleupagus deleted the rm-duplicate-print-download-mask-image branch October 21, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants