-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Editor] Avoid to use event.movementX/Y when resizing an editor #19088
Conversation
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f973452ea010e20/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/a0c5193a9ca76fd/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/f973452ea010e20/output.txt Total script time: 9.07 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/a0c5193a9ca76fd/output.txt Total script time: 18.80 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, thank you.
Those propertie can have some non-expected values so use screenX/Y instead.
1012302
to
c08b5b2
Compare
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/47d6535a35fff05/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/fe65179cbe7ffec/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/fe65179cbe7ffec/output.txt Total script time: 8.77 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/47d6535a35fff05/output.txt Total script time: 18.94 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I missed that the first version of the patch had test-failures, when originally reviewing, since there's still some intermittent failures in the integration-tests.)
Those propertie can have some non-expected values so use screenX/Y instead.