Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly wait for the editor mode when double clicking on an annotation in integration tests #19163

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Correctly wait for the editor mode when double clicking on an annotation in integration tests #19163

merged 1 commit into from
Dec 5, 2024

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1ed7d82ca95fe88/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/c824cabd0710765/output.txt

@calixteman
Copy link
Contributor Author

It should help to fix the issue in #19161 (comment)

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/1ed7d82ca95fe88/output.txt

Total script time: 10.27 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/c824cabd0710765/output.txt

Total script time: 23.41 mins

  • Integration Tests: FAILED

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1e56d934d560f58/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/f651c88700f0ae2/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/1e56d934d560f58/output.txt

Total script time: 10.22 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/f651c88700f0ae2/output.txt

Total script time: 22.92 mins

  • Integration Tests: FAILED

@calixteman
Copy link
Contributor Author

It doesn't fix the issue I can't reproduce locally neither on Windows nor on Linux...
That said these changes don't hurt because they're good enough to at least fix some potential intermittents.

@calixteman
Copy link
Contributor Author

I really don't understand why it's failing... :(
That said, I notice a JavaScript error: http://127.0.0.1:55049/build/generic/build/pdf.mjs, line 12789: TypeError: can't access property "sendWithPromise", this.messageHandler is null, @Snuffleupagus does that ring a bell ?

@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Dec 5, 2024 •
edited
Loading

That said, I notice a JavaScript error: http://127.0.0.1:55049/build/generic/build/pdf.mjs, line 12789: TypeError: can't access property "sendWithPromise", this.messageHandler is null, @Snuffleupagus does that ring a bell ?

That might suggest that something is trying access an API method after the document has already been closed.

Snuffleupagus
Snuffleupagus approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thanks.

@calixteman calixteman merged commit 9cbc5ba into mozilla:master Dec 5, 2024
7 checks passed
@calixteman calixteman deleted the fix_new_ink_itest branch December 5, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
editor test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @moz-tools-bot @Snuffleupagus