Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When zooming replace the css-zoomed canvas by the new one only when rendering is finished #19164

Merged
merged 1 commit into from
Dec 6, 2024
Merged

When zooming replace the css-zoomed canvas by the new one only when rendering is finished #19164

merged 1 commit into from
Dec 6, 2024

Conversation

calixteman
Copy link
Contributor

It fixes #18622.

It avoids to recreate a canvasWrapper element in order minimize the DOM operations.

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/ef5a24ddf5423ca/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/7cde2d853c7831f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/7cde2d853c7831f/output.txt

Total script time: 10.22 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/ef5a24ddf5423ca/output.txt

Total script time: 22.95 mins

  • Integration Tests: FAILED

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/bd42da465b05f87/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/408c8572bb11051/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/408c8572bb11051/output.txt

Total script time: 10.42 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/bd42da465b05f87/output.txt

Total script time: 22.83 mins

  • Integration Tests: Passed

nicolo-ribaudo
nicolo-ribaudo reviewed Dec 5, 2024
View reviewed changes
web/pdf_page_view.js Outdated Show resolved Hide resolved
Snuffleupagus
Snuffleupagus reviewed Dec 5, 2024
View reviewed changes
web/pdf_page_view.js Outdated Show resolved Hide resolved
Snuffleupagus
Snuffleupagus reviewed Dec 5, 2024
View reviewed changes
web/pdf_page_view.js Outdated Show resolved Hide resolved
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6b83205402a999c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8bbbe61eeefbaad/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/8bbbe61eeefbaad/output.txt

Total script time: 10.29 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/6b83205402a999c/output.txt

Total script time: 22.82 mins

  • Integration Tests: Passed

@mozilla mozilla deleted a comment from moz-tools-bot Dec 5, 2024
@mozilla mozilla deleted a comment from moz-tools-bot Dec 5, 2024
Snuffleupagus
Snuffleupagus reviewed Dec 5, 2024
View reviewed changes
web/pdf_page_view.js Outdated Show resolved Hide resolved
web/pdf_page_view.js Outdated Show resolved Hide resolved
web/pdf_page_view.js Show resolved Hide resolved
Snuffleupagus
Snuffleupagus reviewed Dec 5, 2024
View reviewed changes
web/pdf_page_view.js Outdated Show resolved Hide resolved
@calixteman
When zooming replace the css-zoomed canvas by the new one only when r…
f303840 
…endering is finished

It fixes mozilla#18622.

It avoids to recreate a canvasWrapper element in order minimize the DOM operations.
@mozilla mozilla deleted a comment from moz-tools-bot Dec 6, 2024
@mozilla mozilla deleted a comment from moz-tools-bot Dec 6, 2024
@Snuffleupagus
Copy link
Collaborator

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0a215e28cc91da1/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e4a23184a2cc5c1/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/0a215e28cc91da1/output.txt

Total script time: 10.33 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/e4a23184a2cc5c1/output.txt

Total script time: 23.13 mins

  • Integration Tests: FAILED

Snuffleupagus
Snuffleupagus approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, besides fixing a regression this patch feels like an overall improvement of this code; thank you.

@calixteman calixteman merged commit e04b62b into mozilla:master Dec 6, 2024
7 checks passed
@calixteman calixteman deleted the issue18622 branch December 6, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo left review comments

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Regression] The zoomLayer-functionality is broken after PR 17817
4 participants
@calixteman @moz-tools-bot @Snuffleupagus @nicolo-ribaudo