Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support toggling the PDFFindBar options with the Enter key (issue 19175) #19185

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

Snuffleupagus
Copy link
Collaborator

These DOM elements are input type="checkbox" and (natively) only support being toggled with the Space key, however we can extend an existing event-listener to "manually" support the Enter key as well.

web/pdf_find_bar.js Outdated Show resolved Hide resolved
… 19175)

These DOM elements are `input type="checkbox"` and (natively) only support being toggled with the `Space` key, however we can extend an existing event-listener to "manually" support the `Enter` key as well.
@mozilla mozilla deleted a comment from moz-tools-bot Dec 6, 2024
@mozilla mozilla deleted a comment from moz-tools-bot Dec 6, 2024
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5845e27b21906bb/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/5845e27b21906bb/output.txt

Total script time: 0.98 mins

Published

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit b870c5d into mozilla:master Dec 6, 2024
7 checks passed
@Snuffleupagus Snuffleupagus deleted the issue-19175 branch December 6, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Pressing enter key to toggle/untoggle one of the buttons in the find bar doesn't work
4 participants