Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the raw path-strings after creating the actual Path2D glyph-objects #19200

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

Snuffleupagus
Copy link
Collaborator

The Path2D glyph-objects are cached on the FontFaceObject-instance, so we can save a little bit of memory by removing the raw path-strings once they're no longer needed.

…objects

The `Path2D` glyph-objects are cached on the `FontFaceObject`-instance, so we can save a little bit of memory by removing the raw path-strings once they're no longer needed.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/30725b7bfbf3aec/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/30725b7bfbf3aec/output.txt

Total script time: 52.43 mins

  • Unit tests: FAILED
  • Integration Tests: FAILED
  • Regression tests: Passed

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit 39bfc92 into mozilla:master Dec 9, 2024
9 checks passed
@Snuffleupagus Snuffleupagus deleted the delete-raw-path branch December 9, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants