-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For images that include SMask/Mask entries, ignore an SMask defined in the current graphics state (bug 986450) #19269
Conversation
…n the current graphics state From section [11.6.4.3 Mask Shape and Opacity](https://opensource.adobe.com/dc-acrobat-sdk-docs/pdfstandards/PDF32000_2008.pdf#G10.4848628) in the PDF specification: - An image XObject may contain its own *soft-mask image* in the form of a subsidiary image XObject in the `SMask` entry of the image dictionary (see "Image Dictionaries"). This mask, if present, shall override any explicit or colour key mask specified by the image dictionary's `Mask` entry. Either form of mask in the image dictionary shall override the current soft mask in the graphics state.
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/3422cea5ad31e36/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/092ea0424db2d14/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/3422cea5ad31e36/output.txt Total script time: 3.35 mins
Image differences available at: http://54.193.163.58:8877/3422cea5ad31e36/reftest-analyzer.html#web=eq.log |
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/89da29697935762/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/092ea0424db2d14/output.txt Total script time: 27.85 mins
Image differences available at: http://54.241.84.105:8877/092ea0424db2d14/reftest-analyzer.html#web=eq.log |
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/fa065d563d59026/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/fa065d563d59026/output.txt Total script time: 0.88 mins Published |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/89da29697935762/output.txt Total script time: 53.49 mins
Image differences available at: http://54.193.163.58:8877/89da29697935762/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/39fdb07444437f0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/0b3b4efb869a4e3/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/39fdb07444437f0/output.txt Total script time: 16.99 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/0b3b4efb869a4e3/output.txt Total script time: 27.14 mins
|
Wow thank you @SehoAhn and @Snuffleupagus, I used this to fix https://issues.apache.org/jira/browse/PDFBOX-5307 . |
From section 11.6.4.3 Mask Shape and Opacity in the PDF specification:
SMask
entry of the image dictionary (see "Image Dictionaries"). This mask, if present, shall override any explicit or colour key mask specified by the image dictionary'sMask
entry. Either form of mask in the image dictionary shall override the current soft mask in the graphics state.