Simplify the NetworkManager.prototype.requestRange method
#19272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to modern JavaScript we don't need to "manually" build the arguments object.
Snuffleupagus
force-pushed
the
NetworkManager-requestRange
branch
from
57e7a3e to
303c6d9
Compare
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/512b850acc14abd/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/70a9b70377e0f95/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/512b850acc14abd/output.txt Total script time: 2.31 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/70a9b70377e0f95/output.txt Total script time: 7.15 mins
|
calixteman
reviewed
Dec 31, 2024
| args[prop] = listeners[prop]; | ||
| } | ||
| return this.request(args); | ||
| return this.request({ begin, end, ...listeners }); |
There was a problem hiding this comment.
Can't we just have requestRange(options) { return this.request(optinos); } ?
There was a problem hiding this comment.
This comment made me take another look at the code, so I've just submitted PR #19273 instead :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to modern JavaScript we don't need to "manually" build the arguments object.