refactor src/core/pdf_manager.js: rename pdfModel to pdfDocument #4440
Conversation
Rename pdfModel to pdfDocument to let the name closer resemble what the variable actually holds
| @@ -33,24 +33,24 @@ var BasePdfManager = (function BasePdfManagerClosure() { | |||
| throw new NotImplementedException(); | |||
| }, | |||
|
|
|||
| ensureModel: function BasePdfManager_ensureModel(prop, args) { | |||
| return this.ensure(this.pdfModel, prop, args); | |||
| ensureDoc: function BasePdfManager_ensureDoc(prop, args) { | |||
There was a problem hiding this comment.
The other changes are fine, but this one seems confusing since it doesn't ensure the doc is ready. I'd say leave as is or something like ensureDocumentProperty
There was a problem hiding this comment.
On second glance I guess this look like the other ensure* functions.
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://107.21.233.14:8877/d3b956cd9385056/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 3 Live output at: http://107.22.172.223:8877/fa24a308f65126e/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/d3b956cd9385056/output.txt Total script time: 25.79 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/fa24a308f65126e/output.txt Total script time: 37.08 mins
|
refactor src/core/pdf_manager.js: rename pdfModel to pdfDocument
Renamed
pdfModeltopdfDocumentto let the name closer resemble what thevariable actually holds. Function
ensureModelrenamed accordingly toensureDoc.