Fix download button waiting if document has started but not completed downloading #4455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/51e08113710fdcf/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/51e08113710fdcf/output.txt Total script time: 0.44 mins Published
|
|
Great! This has been bugging me for a while, so it's nice to see a patch for this. |
yurydelendik
added a commit
that referenced
this pull request
Apr 3, 2014
Fix download button waiting if document has started but not completed downloading
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1826
The "download from cache" feature works like a charm but is currently triggered when a document starts downloading/displaying. (A plain "download from URL" is used when the document has not even started that). This commit keeps track of a document's download completion status and falls back to "download from URL" if it is not in the cache, making the download button consistently responsive.