Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor src/core/pdf_manager.js: rename pdfModel to pdfDocument #4481

Merged
merged 2 commits into from
Mar 19, 2014

Conversation

bthorben
Copy link
Contributor

Fix #4480, only changes in src/core/worker.js below line 296 are new. It's amazing that all tests didn't find this error?!

@Snuffleupagus
Copy link
Collaborator

This looks a bit strange, since most of these changes are already present in: https://github.com/mozilla/pdf.js/blob/master/src/core/pdf_manager.js.

Did you by any chance base this PR on an older version of the repo?

@bthorben
Copy link
Contributor Author

It's a fixup to an already merged version and should replace that commit. The only other option is to treat it as something completely new, which it isn't (at least in my eyes). I comes down on how you want to organise things.

@yurydelendik
Copy link
Contributor

After squash (as done per wiki) the commit shall look like 8175753

@brendandahl
Copy link
Contributor

It's amazing that all tests didn't find this error?!

Yes, lets add a test https://github.com/mozilla/pdf.js/blob/master/test/unit/api_spec.js

@bthorben
Copy link
Contributor Author

I will see what I can do tomorrow morning

Thorben Bochenek added 2 commits March 19, 2014 09:43
Rename pdfModel to pdfDocument to let the name closer resemble what the
variable actually holds
@bthorben
Copy link
Contributor Author

Added a test that correctly fails without this patch, I like jasmine

@Snuffleupagus
Copy link
Collaborator

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/e56b51525b4570b/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/0c15db400e5a551/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/e56b51525b4570b/output.txt

Total script time: 25.83 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/0c15db400e5a551/output.txt

Total script time: 37.25 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

yurydelendik added a commit that referenced this pull request Mar 19, 2014
refactor src/core/pdf_manager.js: rename pdfModel to pdfDocument
@yurydelendik yurydelendik merged commit 305274c into mozilla:master Mar 19, 2014
@yurydelendik
Copy link
Contributor

Thank you

@bthorben bthorben deleted the refactor/pdf_manager.js branch March 19, 2014 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants