-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CSS rules to improve scrolling on iOS devices #4516
Conversation
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/f9e1f5ed742ca60/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/f9e1f5ed742ca60/output.txt Total script time: 0.31 mins Published
|
to keep it from responding to touch */ | ||
#overlayContainer.hidden + #mainContainer > #viewerContainer { | ||
-webkit-overflow-scrolling: touch; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move the comment inside the block and add something with '-webkit-' to the statement so it will be removed by the preprocessor, e.g.
#overlayContainer.hidden[not(-webkit-if)] + #mainContainer > #viewerContainer {
/* This disables momentum scrolling when overlayContainer is visible
to keep it from responding to touch */
-webkit-overflow-scrolling: touch;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#overlayContainer.hidden + #mainContainer > #viewerContainer /* -webkit-if */ {
works too
Done |
Removing the momentum scrolling when the overlayContainer is visible seems to add a "flicker" effect on some device when, for exemple, the user opens the document properties. I am looking into it. |
@yurydelendik: It seems to be OK now (and simpler) |
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/091a0083965912b/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/091a0083965912b/output.txt Total script time: 0.42 mins Published
|
@yurydelendik Is this good to go? |
Looks good. Thanks. |
Added CSS rules to improve scrolling on iOS devices
These CSS rules make scrolling smoother on iOS devices.