Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CSS rules to improve scrolling on iOS devices #4516

Merged
merged 1 commit into from Apr 3, 2014
Merged

Added CSS rules to improve scrolling on iOS devices #4516

merged 1 commit into from Apr 3, 2014

Conversation

ghost
Copy link

@ghost ghost commented Mar 25, 2014

These CSS rules make scrolling smoother on iOS devices.

@ghost ghost closed this Mar 25, 2014
@ghost ghost reopened this Mar 25, 2014
@yurydelendik
Copy link
Contributor

/botio-windows preview

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_preview from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/f9e1f5ed742ca60/output.txt

to keep it from responding to touch */
#overlayContainer.hidden + #mainContainer > #viewerContainer {
-webkit-overflow-scrolling: touch;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move the comment inside the block and add something with '-webkit-' to the statement so it will be removed by the preprocessor, e.g.

#overlayContainer.hidden[not(-webkit-if)] + #mainContainer > #viewerContainer {
    /* This disables momentum scrolling when overlayContainer is visible
       to keep it from responding to touch */
  -webkit-overflow-scrolling: touch;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#overlayContainer.hidden + #mainContainer > #viewerContainer /* -webkit-if */ { works too

@ghost
Copy link
Author

ghost commented Mar 26, 2014

Done

@ghost
Copy link
Author

ghost commented Mar 26, 2014

Removing the momentum scrolling when the overlayContainer is visible seems to add a "flicker" effect on some device when, for exemple, the user opens the document properties. I am looking into it.

@ghost
Copy link
Author

ghost commented Mar 31, 2014

@yurydelendik: It seems to be OK now (and simpler)

@yurydelendik
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/091a0083965912b/output.txt

@timvandermeij
Copy link
Contributor

@yurydelendik Is this good to go?

@yurydelendik
Copy link
Contributor

Looks good. Thanks.

yurydelendik added a commit that referenced this pull request Apr 3, 2014
Added CSS rules to improve scrolling on iOS devices
@yurydelendik yurydelendik merged commit 4be65a9 into mozilla:master Apr 3, 2014
@ghost ghost deleted the ios-scrolling branch April 4, 2014 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants