Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heuristics to recognize the unknown glyphs for toUnicode #4550

Merged
merged 2 commits into from
Apr 11, 2014

Conversation

yurydelendik
Copy link
Contributor

Attempt to address #4548

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Apr 2, 2014

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/ddf748a13b7ebfa/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 2, 2014

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/75f185044b2e007/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 2, 2014

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/75f185044b2e007/output.txt

Total script time: 21.86 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Apr 2, 2014

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/ddf748a13b7ebfa/output.txt

Total script time: 25.55 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@brendandahl
Copy link
Contributor

Seems like a lot of code to fix a bad pdf. I'd say since we match acrobat, we don't fix.

@yurydelendik
Copy link
Contributor Author

That's my point :) closing pr and the issue?

@yurydelendik yurydelendik changed the title Recovering toUnicode for Mac Quartz Heuristics to recognize the unknown glyphs for toUnicode Apr 9, 2014
@yurydelendik
Copy link
Contributor Author

A better solution.

Fixes #4562

@yurydelendik
Copy link
Contributor Author

/botio-linux preview

@brendandahl is this better?

@pdfjsbot
Copy link

pdfjsbot commented Apr 9, 2014

From: Bot.io (Linux)


Received

Command cmd_preview from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/f7c60101db72dfd/output.txt

@yurydelendik
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Apr 9, 2014

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 1

Live output at: http://107.21.233.14:8877/44a6553b2fefa58/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 9, 2014

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/17af5aab8cf6152/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 9, 2014

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/17af5aab8cf6152/output.txt

Total script time: 2.45 mins

  • Font tests: FAILED
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/17af5aab8cf6152/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Apr 9, 2014

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/44a6553b2fefa58/output.txt

Total script time: 25.73 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/44a6553b2fefa58/reftest-analyzer.html#web=eq.log

@yurydelendik
Copy link
Contributor Author

/botio-windows test

@pdfjsbot
Copy link

pdfjsbot commented Apr 9, 2014

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/e9981bd458d03f1/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 9, 2014

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/e9981bd458d03f1/output.txt

Total script time: 21.86 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@brendandahl
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://107.21.233.14:8877/cafecf3a38dd675/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://107.22.172.223:8877/09f6eb74528a781/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/09f6eb74528a781/output.txt

Total script time: 23.06 mins

  • Lint: Ignored
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/cafecf3a38dd675/output.txt

Total script time: 26.14 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@brendandahl
Copy link
Contributor

rebase me

@yurydelendik
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/aa340c161a64a12/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/5a0838b59ea1908/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/aa340c161a64a12/output.txt

Total script time: 21.95 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/5a0838b59ea1908/output.txt

Total script time: 25.88 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@yurydelendik
Copy link
Contributor Author

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/546f5575efa3378/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/1250e39c4a6b98c/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/546f5575efa3378/output.txt

Total script time: 23.23 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/1250e39c4a6b98c/output.txt

Total script time: 25.70 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

yurydelendik added a commit that referenced this pull request Apr 11, 2014
Heuristics to recognize the unknown glyphs for toUnicode
@yurydelendik yurydelendik merged commit 9385472 into mozilla:master Apr 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants