Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors history and how the database is stored #4559

Merged
merged 1 commit into from
Apr 3, 2014

Conversation

yurydelendik
Copy link
Contributor

Pros:

  • Firefox will not store any history of the browsed files permanently, so no keeping of the trail

Cons:

  • Firefox will not store any history of the browsed files permanently, so no restore of the current PDF position after browser is closed

@Snuffleupagus
Copy link
Collaborator

so no restore of the current PDF position after browser is closed

Unless you choose to save the current tabs on exit, because in this case the browsing history should provide this functionality.

Edit: That doesn't actually appear to be working as I thought, so please ignore the comment above.

@@ -39,6 +39,7 @@ var ViewHistory = (function ViewHistoryClosure() {

var resolvePromise = (function ViewHistoryResolvePromise(db) {
this.isInitializedPromiseResolved = true;
console.log(db);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left-over from debugging?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@brendandahl
Copy link
Contributor

Works for me. @Mossop Any review comments?

@Mossop
Copy link
Member

Mossop commented Apr 3, 2014

Looks fine

brendandahl added a commit that referenced this pull request Apr 3, 2014
Refactors history and how the database is stored
@brendandahl brendandahl merged commit d898717 into mozilla:master Apr 3, 2014
@yurydelendik yurydelendik deleted the history branch April 11, 2014 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants