Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 'space' character correctly in MacRomanEncoding (bug 878026) #4569

Merged
merged 1 commit into from
Apr 9, 2014
Merged

Handle 'space' character correctly in MacRomanEncoding (bug 878026) #4569

merged 1 commit into from
Apr 9, 2014

Conversation

Snuffleupagus
Copy link
Collaborator

According to the specification, using MacRomanEncoding the "space" character could also be encoded as 312 (= 202 decimal), see Note 6 here: http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/PDF32000_2008.pdf#page=664.

Currently MacRomanEncoding[202] = '' (fonts.js#L161), and given fonts.js#L4210 this explains why the "Ecircumflex" character is rendered.

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=878026.

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Apr 7, 2014

From: Bot.io (Linux)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/a10a71131aab410/output.txt

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Apr 7, 2014

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/55644d29e69b0cf/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 7, 2014

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/0c1748018661960/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 7, 2014

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/0c1748018661960/output.txt

Total script time: 21.90 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Apr 7, 2014

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/55644d29e69b0cf/output.txt

Total script time: 25.87 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@yurydelendik
Copy link
Contributor

Nice, thanks

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Apr 9, 2014

From: Bot.io (Windows)


Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/9f878da9c7b4f86/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 9, 2014

From: Bot.io (Linux)


Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/94796b8c50cc21a/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 9, 2014

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/9f878da9c7b4f86/output.txt

Total script time: 22.21 mins

  • Lint: Ignored
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Apr 9, 2014

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/94796b8c50cc21a/output.txt

Total script time: 25.98 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

yurydelendik added a commit that referenced this pull request Apr 9, 2014
Handle 'space' character correctly in MacRomanEncoding (bug 878026)
@yurydelendik yurydelendik merged commit 7a321db into mozilla:master Apr 9, 2014
@Snuffleupagus Snuffleupagus deleted the bug-878026 branch April 9, 2014 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants