Redo and add more documentation to gh-pages. #4585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cd(GENERIC_DIR); | ||
| var distFilename = 'pdfjs-' + VERSION + '-dist.zip'; | ||
| exec('zip -r ' + ROOT_DIR + BUILD_DIR + distFilename + ' *'); | ||
| echo('Built distrobution file: ' + distFilename); |
There was a problem hiding this comment.
nit: typo in 'distribution'
|
We need to add LICENSE to the zip |
|
No reference to wiki (page) and/or FAQs (Tab?) |
|
On getting started, in the note about the viewer, I would also add that they have to understand that responsibility of securing and updating falls on the their shoulders. |
|
Looks good with config changed to the nightly and aurora build numbers |
brendandahl
added a commit
that referenced
this pull request
Apr 10, 2014
Redo and add more documentation to gh-pages.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install wintersmith globally and run
wintersmith previewor build web and open build/gh-pages.You'll probably notice this links to release zip files. I'd like to use github releases which for now will be a manual process:
git checkout <SHA IN MOZ CENTRAL>node make distto generate the zip and update pdfjs.confg