Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix seac regression. #4596

Merged
merged 1 commit into from
Apr 11, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 32 additions & 11 deletions src/core/fonts.js
Original file line number Diff line number Diff line change
Expand Up @@ -2471,7 +2471,8 @@ var Font = (function FontClosure() {
}
return {
toFontChar: toFontChar,
charCodeToGlyphId: newMap
charCodeToGlyphId: newMap,
nextAvailableFontCharCode: nextAvailableFontCharCode
};
}

Expand Down Expand Up @@ -4046,18 +4047,25 @@ var Font = (function FontClosure() {
this.toFontChar = newMapping.toFontChar;
var numGlyphs = font.numGlyphs;

function getCharCode(charCodeToGlyphId, glyphId, addMap) {
for (var charCode in charCodeToGlyphId) {
if (glyphId === charCodeToGlyphId[charCode]) {
return charCode | 0;
}
}
if (addMap) {
newMapping.charCodeToGlyphId[newMapping.nextAvailableFontCharCode] =
glyphId;
return newMapping.nextAvailableFontCharCode++;
}
return null;
}

var seacs = font.seacs;
var charCode;
if (SEAC_ANALYSIS_ENABLED && seacs && seacs.length) {
var matrix = properties.fontMatrix || FONT_IDENTITY_MATRIX;
var charset = font.getCharset();
var charCodeToGlyphId = mapping;
var toFontChar = newMapping.toFontChar;
var seacMap = Object.create(null);
var glyphIdToCharCode = Object.create(null);
for (charCode in charCodeToGlyphId) {
glyphIdToCharCode[charCodeToGlyphId[charCode]] = charCode | 0;
}
for (var glyphId in seacs) {
glyphId |= 0;
var seac = seacs[glyphId];
Expand All @@ -4072,10 +4080,23 @@ var Font = (function FontClosure() {
x: seac[0] * matrix[0] + seac[1] * matrix[2] + matrix[4],
y: seac[0] * matrix[1] + seac[1] * matrix[3] + matrix[5]
};
charCode = glyphIdToCharCode[glyphId];

var charCode = getCharCode(mapping, glyphId);
if (charCode === null) {
// There's no point in mapping it if the char code was never mapped
// to begin with.
continue;
}
// Find a fontCharCode that maps to the base and accent glyphs. If one
// doesn't exists, create it.
var charCodeToGlyphId = newMapping.charCodeToGlyphId;
var baseFontCharCode = getCharCode(charCodeToGlyphId, baseGlyphId,
true);
var accentFontCharCode = getCharCode(charCodeToGlyphId, accentGlyphId,
true);
seacMap[charCode] = {
baseFontCharCode: toFontChar[glyphIdToCharCode[baseGlyphId]],
accentFontCharCode: toFontChar[glyphIdToCharCode[accentGlyphId]],
baseFontCharCode: baseFontCharCode,
accentFontCharCode: accentFontCharCode,
accentOffset: accentOffset
};
}
Expand Down
1 change: 1 addition & 0 deletions test/pdfs/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -71,3 +71,4 @@
!bug859204.pdf
!issue4246.pdf
!issue4461.pdf
!issue4573.pdf
Binary file added test/pdfs/issue4573.pdf
Binary file not shown.
10 changes: 10 additions & 0 deletions test/test_manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -665,6 +665,16 @@
"rounds": 1,
"type": "eq"
},
{ "id": "issue4573",
"file": "pdfs/issue4573.pdf",
"md5": "34b0c4fdee19e57033275b766c5f57a3",
"rounds": 1,
"link": false,
"firstPage": 1,
"lastPage": 1,
"type": "eq",
"about": "Seac with differences array that messes up mapping."
},
{ "id": "ocs",
"file": "pdfs/ocs.pdf",
"md5": "2ade57e954ae7632749cf328daeaa7a8",
Expand Down