-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove LegacyPromise in src/core/chunked_stream.js #4667
Remove LegacyPromise in src/core/chunked_stream.js #4667
Conversation
blocking by #4700 to have a good pattern of storing resolve/reject methods. |
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 1 Live output at: http://107.22.172.223:8877/de093507fff6fed/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 1 Live output at: http://107.21.233.14:8877/d7e1874e7ce96af/output.txt |
Since we discussed on IRC that there currently is no way to reject the promise if there are errors, should we also in preparation for better error handling add a function that does that?
|
Yes. You are welcome to add the logic now or follow up on this later, when we start enforcing that. |
... otherwise looks good, you can land it as is |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/de093507fff6fed/output.txt Total script time: 22.35 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/d7e1874e7ce96af/output.txt Total script time: 25.67 mins
|
…ked_stream.js Remove LegacyPromise in src/core/chunked_stream.js
No description provided.