Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LegacyPromise in src/core/chunked_stream.js #4667

Merged
merged 2 commits into from
May 1, 2014
Merged

Remove LegacyPromise in src/core/chunked_stream.js #4667

merged 2 commits into from
May 1, 2014

Conversation

Snuffleupagus
Copy link
Collaborator

No description provided.

@yurydelendik
Copy link
Contributor

blocking by #4700 to have a good pattern of storing resolve/reject methods.

@yurydelendik
Copy link
Contributor

#4700 merged, see also #4430 for patterns

@yurydelendik
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

pdfjsbot commented May 1, 2014

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 1

Live output at: http://107.22.172.223:8877/de093507fff6fed/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 1, 2014

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 1

Live output at: http://107.21.233.14:8877/d7e1874e7ce96af/output.txt

@Snuffleupagus
Copy link
Collaborator Author

Since we discussed on IRC that there currently is no way to reject the promise if there are errors, should we also in preparation for better error handling add a function that does that?
E.g. something like this:

onError: function ChunkedStreamManager_onError(err) {
  this._loadedStreamCapability.reject(err);
},

@yurydelendik
Copy link
Contributor

Since we discussed on IRC that there currently is no way to reject the promise if there are errors, should we also in preparation for better error handling add a function that does that?

Yes. You are welcome to add the logic now or follow up on this later, when we start enforcing that.

@yurydelendik
Copy link
Contributor

... otherwise looks good, you can land it as is

@pdfjsbot
Copy link

pdfjsbot commented May 1, 2014

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/de093507fff6fed/output.txt

Total script time: 22.35 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented May 1, 2014

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/d7e1874e7ce96af/output.txt

Total script time: 25.67 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

timvandermeij added a commit that referenced this pull request May 1, 2014
…ked_stream.js

Remove LegacyPromise in src/core/chunked_stream.js
@timvandermeij timvandermeij merged commit 4224bae into mozilla:master May 1, 2014
@Snuffleupagus Snuffleupagus deleted the remove-LegacyPromise-chunked_stream.js branch May 1, 2014 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants