Converts attachment items to buttons instead of links #4686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| padding: 2px 0 5px 10px; | ||
| } | ||
| html[dir='ltr'] .attachmentsItem > button { | ||
| padding: 2px 0 3px 10px; |
There was a problem hiding this comment.
Close, but I think you might have to tweak these values somewhat (if you want to maintain the current look).
There was a problem hiding this comment.
I see. I've fix this now and compared it by switching between tabs with my patch and the current version. It looks identical now.
|
r+ for solution, ready to land you will be happy with the look. thanks |
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/f2b8cb6422cfc7f/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/f2b8cb6422cfc7f/output.txt Total script time: 0.38 mins Published
|
timvandermeij
added a commit
that referenced
this pull request
Apr 25, 2014
Converts attachment items to buttons instead of links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4681.