Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build paths for glyph accents when drawing text as curves #4736

Merged
merged 1 commit into from
May 14, 2014
Merged

Build paths for glyph accents when drawing text as curves #4736

merged 1 commit into from
May 14, 2014

Conversation

Snuffleupagus
Copy link
Collaborator

This PR fixes (taken from the list at http://bthorben.github.io/pdfRepo/#crashed):

Note: even though this PR fixes the error that prevents the files from rendering completely, there is still a slight issue with the second file. At the bottom of the page, the dots above the u are placed too far to the left. However that is probably better to handle in a follow-up, since it's most likely an issue with the font data in that particular file.
pdfjs

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2014

From: Bot.io (Linux)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/2560b4b3c72e990/output.txt

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2014

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/db13eaf5041aa83/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2014

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/c443b1d2d50f523/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2014

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/c443b1d2d50f523/output.txt

Total script time: 22.20 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2014

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/db13eaf5041aa83/output.txt

Total script time: 25.65 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@yurydelendik yurydelendik added this to the 2014 Q2 milestone May 5, 2014
@bthorben
Copy link
Contributor

bthorben commented May 8, 2014

It's really amazing how active the project is. Thanks for fixing the crashed PDFs!

@Snuffleupagus Snuffleupagus modified the milestone: 2014 Q2 May 8, 2014
@timvandermeij
Copy link
Contributor

@Snuffleupagus Could you add a test to the PR? It looks good otherwise.

@Snuffleupagus
Copy link
Collaborator Author

Now with test case added!

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/2e8728c7f7d660b/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/52582002898621c/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/52582002898621c/output.txt

Total script time: 23.61 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/2e8728c7f7d660b/output.txt

Total script time: 26.12 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@yurydelendik
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/091271afc868763/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/8546cb3ce411d4a/output.txt

yurydelendik added a commit that referenced this pull request May 14, 2014
Build paths for glyph accents when drawing text as curves
@yurydelendik yurydelendik merged commit 048c6d9 into mozilla:master May 14, 2014
@yurydelendik
Copy link
Contributor

Gracias

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/8546cb3ce411d4a/output.txt

Total script time: 24.01 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/091271afc868763/output.txt

Total script time: 26.39 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus deleted the glyph-accent-buildPath branch May 14, 2014 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants