Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring annotation.js and removing old TODOs/comments #4759

Merged
merged 2 commits into from
May 9, 2014

Conversation

timvandermeij
Copy link
Contributor

No description provided.

@timvandermeij
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented May 8, 2014

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/85af8d869640a4f/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 8, 2014

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/5e779248219b4cd/output.txt

@timvandermeij timvandermeij changed the title Refactors annotation.js and removes old comments Refactoring annotation.js and removing old TODOs/comments May 8, 2014
@pdfjsbot
Copy link

pdfjsbot commented May 8, 2014

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/85af8d869640a4f/output.txt

Total script time: 23.18 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented May 8, 2014

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/5e779248219b4cd/output.txt

Total script time: 25.71 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

yurydelendik added a commit that referenced this pull request May 9, 2014
Refactoring annotation.js and removing old TODOs/comments
@yurydelendik yurydelendik merged commit 12d9022 into mozilla:master May 9, 2014
@yurydelendik
Copy link
Contributor

Thank you

@timvandermeij timvandermeij deleted the old-code branch May 9, 2014 19:11
xlc added a commit to KamiHQ/pdf.js that referenced this pull request Jan 5, 2016
Note: currently data.font* are always undefined because
mozilla#4759 removed the code that
updates it
xlc added a commit to KamiHQ/pdf.js that referenced this pull request Feb 14, 2016
Note: currently data.font* are always undefined because
mozilla#4759 removed the code that
updates it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants