Let Parser_makeFilter return NullStream when an invalid stream is encountered (issue 3417) #4945
Conversation
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/89a9a0a53377dba/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/89a9a0a53377dba/output.txt Total script time: 0.73 mins Published
|
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/42780c5c5a2dfb4/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/c6189d956cf0b20/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/42780c5c5a2dfb4/output.txt Total script time: 20.75 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/c6189d956cf0b20/output.txt Total script time: 24.74 mins
|
…ountered (issue 3417)
|
I don't think we shall throw the exception in the constructor anyway (if this case FlateStream) -- we shall throw it when we started decoding. To make it easy, can we just throw warning in the constructor and make stream empty? On different note, it looks like the stream is encoded using Deflate64, we shall look if we can add than to PDF.js. |
That seems to work just fine. The error is indeed triggered when decoding the stream, which enables the rest of the page to load.
I'm guessing that you meant setting |
|
Okay, it's good as is /botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/3a18c6243a5c98f/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/a5fab83d0521771/output.txt |
| } | ||
| warn('filter "' + name + '" not supported yet'); | ||
| return stream; | ||
| } catch (ex) { |
There was a problem hiding this comment.
we shall not catch MissingDataException here
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/3a18c6243a5c98f/output.txt Total script time: 21.46 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/a5fab83d0521771/output.txt Total script time: 23.76 mins
|
|
Thank you |
Fixes #3417.
(For simpler reviewing, use https://github.com/mozilla/pdf.js/pull/4945/files?w=1)