Zero the height and width of cached canvases before deleting them. #4959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces peak RSS by about 300 MiB on my Mac when scrolling slowly through the first 30 pages of a scanned black and white document.
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/103712cf63fd747/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/e2430863f90b54c/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/103712cf63fd747/output.txt Total script time: 21.63 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/e2430863f90b54c/output.txt Total script time: 24.02 mins
|
yurydelendik
added a commit
that referenced
this pull request
Jun 17, 2014
Zero the height and width of cached canvases before deleting them.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is exactly the same idea as #4920, but for CachedCanvases.
This reduces peak RSS from ~1400 MiB to ~1100 MiB on my Mac when scrolling slowly through
the first 30 pages of a scanned black and white document.