Use null instead of [] for ops with no args. #4982
Conversation
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/277bf98d9b6916c/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/d03ce7c673db512/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/277bf98d9b6916c/output.txt Total script time: 21.32 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/d03ce7c673db512/output.txt Total script time: 23.87 mins
|
| @@ -2127,28 +2132,34 @@ var EvaluatorPreprocessor = (function EvaluatorPreprocessorClosure() { | |||
|
|
|||
| if (!opSpec.variableArgs) { | |||
| // Some post script commands can be nested, e.g. /F2 /GS2 gs 5.711 Tf | |||
| if (args.length !== numArgs) { | |||
| var argsLength = args ? args.length : 0; | |||
There was a problem hiding this comment.
you could do args !== null for a faster and stricter check.
This reduces peak RSS on one test file from ~600 to ~560 MiB.
|
I updated the patch as per Fabian's suggestion. |
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/4ecfa9ad13dfe3f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/d733c3a7fba26a8/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/d733c3a7fba26a8/output.txt Total script time: 21.20 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/4ecfa9ad13dfe3f/output.txt Total script time: 23.97 mins
|
Use null instead of [] for ops with no args.
|
Thank you for the patch |
This reduces peak RSS on one test file from ~600 to ~560 MiB.