Avoid creating intermediate strings in Util.makeCssRgb().

[nnethercote]

On one example (the Wuppertal map) this avoids the creation of over
230,000 intermediate strings.

[timvandermeij]

Nice find! Is there a measurable performance difference for that map PDF?

[CodingFabian]

I tried my spoortkart map pdf:

browser	stat	Count	Baseline(ms)	Current(ms)	+/-	%	Result(P<.05)
chrome35	Overall	10	13160	12992	-168	-1.28
chrome35	Page Request	10	16	12	-4	-23.46
chrome35	Rendering	10	13143	12979	-164	-1.25

have a link to the wuppertal map?

[timvandermeij]

@CodingFabian Sure, here you go: http://www.vrr.de/imperia/md/content/fahrten/stadtlinienplaene/wuppertal_2012.pdf

[CodingFabian]

slightly less faster than my dutch map.
i wonder if those rgb strings are really all needed, however this optimization looks useful

browser	stat	Count	Baseline(ms)	Current(ms)	+/-	%	Result(P<.05)
chrome35	Overall	10	6668	6599	-69	-1.03
chrome35	Page Request	10	128	127	-1	-0.78
chrome35	Rendering	10	6540	6471	-68	-1.05

[timvandermeij]

Good to know. Is there also a difference in memory usage? I can imagine that preventing a lot of strings from being created saves a lot of memory.

[nnethercote]

I was unable to detect a peak memory usage improvement because the measurements for this file are really noisy. But it can only be helping. Short strings like these typically take about 16 bytes on 32-bit and 32 bytes on 64-bit, so if we avoid creating 230,000 of them the cumulative reduction in allocations will be something 3.7 or 7.4 MiB. And it results in less stress on the GC, which is always good.

[Snuffleupagus]

/botio test

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/a174375fdd12654/output.txt

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/68285979744f50f/output.txt

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/68285979744f50f/output.txt

Total script time: 36.97 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: Passed

[timvandermeij]

The Windows bot also passed the tests, but no message has been posted. Weird.

[timvandermeij]

Thank you for the patch!