Initialize PDFView.url = '' #5083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The absence of this property caused the following error in PDFView.download: Cannot read property 'split' of undefined This property was unset when the PDF was loaded through a typed array instead of a URL. With the fix, the file name will default to "document.pdf", as defined by getPDFFileNameFromURL in web/ui_utils.js
yurydelendik
added a commit
that referenced
this pull request
Jul 25, 2014
Initialize PDFView.url = ''
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The absence of the
PDFView.urlproperty caused the following error inPDFView.download:This property is unset when the PDF was loaded through a typed array instead of a URL. With the fix, the file name will default to "document.pdf", as defined by
getPDFFileNameFromURLin web/ui_utils.js