Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JBIG2 decoding issue #5026 #5110

Merged
merged 1 commit into from
Aug 1, 2014
Merged

Conversation

fkaelberer
Copy link
Contributor

This PR fixes two issues that caused #5026:

  1. A 0 was missing in the old template (I think Figure 8 in the draft is slightly wrong, the leftmost zero should be in thick borders). Up to the missing zero, the old constants (almost) matched those in xpdf.
  2. We are sorting the template since abcc72a, and so the template bits must be reordered as well. The new constants match those in jbig2dec.

EDIT: Fixed wrong link to the sorting commit.

@Snuffleupagus
Copy link
Collaborator

/botio-windows preview

@pdfjsbot
Copy link

pdfjsbot commented Aug 1, 2014

From: Bot.io (Windows)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/606b13aed7752f4/output.txt

@Snuffleupagus
Copy link
Collaborator

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Aug 1, 2014

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/4c096b9eddcf99c/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 1, 2014

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/137c152aab1f5ad/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 1, 2014

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/4c096b9eddcf99c/output.txt

Total script time: 19.62 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Aug 1, 2014

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/137c152aab1f5ad/output.txt

Total script time: 22.92 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

yurydelendik added a commit that referenced this pull request Aug 1, 2014
@yurydelendik yurydelendik merged commit 6d6e09b into mozilla:master Aug 1, 2014
@yurydelendik
Copy link
Contributor

Thank you for the fix

@fkaelberer fkaelberer deleted the issue5026 branch August 1, 2014 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants