Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict equalities in src/display/* #5113

Merged
merged 5 commits into from
Aug 1, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/display/api.js
Original file line number Diff line number Diff line change
Expand Up @@ -503,8 +503,7 @@ var PDFPageProxy = (function PDFPageProxyClosure() {
// this call to render.
this.pendingDestroy = false;

var renderingIntent = ('intent' in params ?
(params.intent == 'print' ? 'print' : 'display') : 'display');
var renderingIntent = (params.intent === 'print' ? 'print' : 'display');

if (!this.intentStates[renderingIntent]) {
this.intentStates[renderingIntent] = {};
Expand Down Expand Up @@ -1003,7 +1002,7 @@ var WorkerTransport = (function WorkerTransportClosure() {
messageHandler.on('JpegDecode', function(data) {
var imageUrl = data[0];
var components = data[1];
if (components != 3 && components != 1) {
if (components !== 3 && components !== 1) {
return Promise.reject(
new Error('Only 3 components or 1 component can be returned'));
}
Expand All @@ -1022,13 +1021,13 @@ var WorkerTransport = (function WorkerTransportClosure() {
var data = tmpCtx.getImageData(0, 0, width, height).data;
var i, j;

if (components == 3) {
if (components === 3) {
for (i = 0, j = 0; i < rgbaLength; i += 4, j += 3) {
buf[j] = data[i];
buf[j + 1] = data[i + 1];
buf[j + 2] = data[i + 2];
}
} else if (components == 1) {
} else if (components === 1) {
for (i = 0, j = 0; i < rgbaLength; i += 4, j++) {
buf[j] = data[i];
}
Expand Down
4 changes: 2 additions & 2 deletions src/display/canvas.js
Original file line number Diff line number Diff line change
Expand Up @@ -1227,7 +1227,7 @@ var CanvasGraphics = (function CanvasGraphicsClosure() {
// the current transformation matrix before the fillText/strokeText.
// See https://bugzilla.mozilla.org/show_bug.cgi?id=726227
var browserFontSize = size >= MIN_FONT_SIZE ? size : MIN_FONT_SIZE;
this.current.fontSizeScale = browserFontSize != MIN_FONT_SIZE ? 1.0 :
this.current.fontSizeScale = browserFontSize !== MIN_FONT_SIZE ? 1.0 :
size / MIN_FONT_SIZE;

var rule = italic + ' ' + bold + ' ' + browserFontSize + 'px ' + typeface;
Expand Down Expand Up @@ -1373,7 +1373,7 @@ var CanvasGraphics = (function CanvasGraphicsClosure() {
lineWidth /= scale;
}

if (fontSizeScale != 1.0) {
if (fontSizeScale !== 1.0) {
ctx.scale(fontSizeScale, fontSizeScale);
lineWidth /= fontSizeScale;
}
Expand Down
4 changes: 2 additions & 2 deletions src/display/metadata.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ var Metadata = PDFJS.Metadata = (function MetadataClosure() {
var chars = '';
for (var i = 0; i < bytes.length; i += 2) {
var code = bytes.charCodeAt(i) * 256 + bytes.charCodeAt(i + 1);
chars += code >= 32 && code < 127 && code != 60 && code != 62 &&
code != 38 && false ? String.fromCharCode(code) :
chars += code >= 32 && code < 127 && code !== 60 && code !== 62 &&
code !== 38 && false ? String.fromCharCode(code) :
'&#x' + (0x10000 + code).toString(16).substring(1) + ';';
}
return '>' + chars;
Expand Down
2 changes: 1 addition & 1 deletion src/display/pattern_helper.js
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ var TilingPattern = (function TilingPatternClosure() {
},

clipBbox: function clipBbox(graphics, bbox, x0, y0, x1, y1) {
if (bbox && isArray(bbox) && 4 == bbox.length) {
if (bbox && isArray(bbox) && bbox.length === 4) {
var bboxWidth = x1 - x0;
var bboxHeight = y1 - y0;
graphics.ctx.rect(x0, y0, bboxWidth, bboxHeight);
Expand Down
4 changes: 2 additions & 2 deletions src/display/svg.js
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ var SVGGraphics = (function SVGGraphicsClosure(ctx) {

var self = this;
for (var i = 0; i < fnArrayLen; i++) {
if (OPS.dependency == fnArray[i]) {
if (OPS.dependency === fnArray[i]) {
var deps = argsArray[i];
for (var n = 0, nn = deps.length; n < nn; n++) {
var obj = deps[n];
Expand Down Expand Up @@ -652,7 +652,7 @@ var SVGGraphics = (function SVGGraphicsClosure(ctx) {
this.clippath = document.createElementNS(NS, 'svg:clipPath');
this.clippath.setAttributeNS(null, 'id', current.clipId);
var clipElement = current.element.cloneNode();
if (type == 'evenodd') {
if (type === 'evenodd') {
clipElement.setAttributeNS(null, 'clip-rule', 'evenodd');
} else {
clipElement.setAttributeNS(null, 'clip-rule', 'nonzero');
Expand Down