Revert commit 9a41659 (PR 5005) for breaking the loading of certain PDF files in the Firefox addon when range requests are active #5145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DF files in the Firefox addon when range requests are active
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/99c94d3deedf111/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/99c94d3deedf111/output.txt Total script time: 0.76 mins Published
|
|
Interesting, it might be caused by having |
yurydelendik
added a commit
that referenced
this pull request
Aug 7, 2014
Revert commit 9a41659 (PR 5005) for breaking the loading of certain PDF files in the Firefox addon when range requests are active
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After 9a41659 (i.e. the first commit of PR #5005), the first page of http://purasilkthailand.com/static/doc/thai-tc.pdf no longer renders. This is only reproducible in the addon when range requests are active. To reproduce this, make sure that the file is loaded from the server by doing a "skip"-cache reload (e.g. Ctrl + F5).
What's somewhat unfortunate with this regression, is that not only has this already landed on Mozilla Central (see bug 1042307); but it has also been uplifted to the Aurora channel.
/cc @fkaelberer