Small re-factoring of DocumentProperties #5201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the changes made in PR 5169 to enable quicker display of the File size, `setFileSize()` can now be called during file loading. This function parses *and* localizes the file size, where the l10n is a synchronous operation. This patch: * Re-factors `setFileSize()` to *only* update `rawFileSize`, and moves parsing and fetching of the l10n string to a separate method that isn't called until the Document Properties dialog is actually opened. * Adds a couple of checks to make sure that `rawFileSize` is set to a positive number. * Removes the `fileName` and `fileSize` properties. Since they are parsed every time the Document Properties dialog is opened, it doesn't seem necessary to cache them.
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/186dc6f75324051/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/186dc6f75324051/output.txt Total script time: 0.97 mins Published
|
yurydelendik
added a commit
that referenced
this pull request
Aug 16, 2014
Small re-factoring of DocumentProperties
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes made in PR #5169 to enable quicker display of the File size,
setFileSize()can now be called during file loading. This function parses and localizes the file size, where the l10n is a synchronous operation.This patch:
setFileSize()to only updaterawFileSize, and moves parsing and fetching of the l10n string to a separate method that isn't called until the Document Properties dialog is actually opened.rawFileSizeis set to a positive number.fileNameandfileSizeproperties. Since they are parsed every time the Document Properties dialog is opened, it doesn't seem necessary to cache them./cc @timvandermeij Can you please review this?