Fix Zoom box resizing when it's hidden when the viewer loads (issue 5224) #5226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/548ceacbd311a5a/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/548ceacbd311a5a/output.txt Total script time: 0.88 mins Published
|
|
Works perfectly. Thank you. |
| // Note: This is only done if the zoom box is actually visible, | ||
| // since otherwise element.clientWidth will return 0. | ||
| // Note: If the window is narrow enough that the zoom box is not visible, | ||
| // we temporarily show it to be able to adjust it's width. |
There was a problem hiding this comment.
Bad grammar: it's should be its. Fixed in new commit.
|
@timvandermeij Are you up for reviewing this? |
|
Looks good to me and confirmed to be fixed on my LG Nexus 4 phone. Thank you! |
timvandermeij
added a commit
that referenced
this pull request
Sep 5, 2014
Fix Zoom box resizing when it's hidden when the viewer loads (issue 5224)
|
@timvandermeij Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to fix #5224.
@fkaelberer Can you please confirm if this patch fixes the issue?