Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of RGBA buffers in CalRGB colorspace (issue 5270) #5276

Merged
merged 1 commit into from
Sep 8, 2014
Merged

Fix handling of RGBA buffers in CalRGB colorspace (issue 5270) #5276

merged 1 commit into from
Sep 8, 2014

Conversation

Snuffleupagus
Copy link
Collaborator

Fixes #5270.

Note: The file in the issue is only available through a file hosting service, hence I didn't include it as a linked test because of the (fairly large) risk that it becomes unavailable in the future.

Edit: This also fixed https://bugzilla.mozilla.org/show_bug.cgi?id=1108753.

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Sep 8, 2014

From: Bot.io (Linux)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/9f1265fe08d12af/output.txt

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Sep 8, 2014

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/5c761d88e7319e6/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 8, 2014

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/46f7c7372c6f8d3/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 8, 2014

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/5c761d88e7319e6/output.txt

Total script time: 22.42 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/5c761d88e7319e6/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Sep 8, 2014

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/46f7c7372c6f8d3/output.txt

Total script time: 22.58 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/46f7c7372c6f8d3/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator Author

The test failures are caused by a Firefox update (to version 34) on the bots.

@yurydelendik
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Sep 8, 2014

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/381b64113fad22e/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 8, 2014

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 1

Live output at: http://107.21.233.14:8877/3156bba88f6a29f/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 8, 2014

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/381b64113fad22e/output.txt

Total script time: 2.79 mins

  • Font tests: FAILED
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/381b64113fad22e/reftest-analyzer.html#web=eq.log

@yurydelendik
Copy link
Contributor

/botio-windows test

@pdfjsbot
Copy link

pdfjsbot commented Sep 8, 2014

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/67946df747bf1f8/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 8, 2014

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/3156bba88f6a29f/output.txt

Total script time: 22.35 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Sep 8, 2014

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/67946df747bf1f8/output.txt

Total script time: 21.91 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

yurydelendik added a commit that referenced this pull request Sep 8, 2014
Fix handling of RGBA buffers in CalRGB colorspace (issue 5270)
@yurydelendik yurydelendik merged commit f925e7d into mozilla:master Sep 8, 2014
@yurydelendik
Copy link
Contributor

Looks good, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDF file with CalRGB colorspace renders blank
3 participants