Fix the placement of arrows in the zoom box

[Snuffleupagus]

Now that bug 649849 has been fixed, adding support for -moz-appearance: none, the arrow is now too close to the text in the zoom box. This is currently only an issue in Nightly, but assuming the patch doesn't get backed out, this will soon affect all versions of Firefox.

This is an illustration of the issue:

Edit: Should also fix https://bugzilla.mozilla.org/show_bug.cgi?id=1102063.

[yurydelendik]

/botio-linux preview

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_preview from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/f0e92e7997ea8c9/output.txt

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/f0e92e7997ea8c9/output.txt

Total script time: 0.76 mins

Published

• Viewer: http://107.21.233.14:8877/f0e92e7997ea8c9/web/viewer.html
• B2G Viewer: http://107.21.233.14:8877/f0e92e7997ea8c9/extensions/b2g/content/web/viewer.html
• Extension: http://107.21.233.14:8877/f0e92e7997ea8c9/extensions/firefox/pdf.js.xpi
• Extension (AMO): http://107.21.233.14:8877/f0e92e7997ea8c9/extensions/firefox/pdf.js.amo.xpi

[yurydelendik]

Looks like there is no effect on Firefox Nightly for Mac OSX

[Snuffleupagus]

Looks like there is no effect on Firefox Nightly for Mac OSX

That's unfortunate, but perhaps not too surprising given that this seemed like a bad hack at the time.

Before I attempt to look into this again: Do we actually want to try and address this issue?
If so, the simplest "solution" is probably to just remove https://github.com/mozilla/pdf.js/blob/master/web/viewer.css#L753, but that seems like a strange way to handle this.
Another idea would be to increase https://github.com/mozilla/pdf.js/blob/master/web/viewer.js#L35 a bit, so there's at least a some distance between the text and the arrows.

[Snuffleupagus]

According to https://bugzilla.mozilla.org/show_bug.cgi?id=1102063#c5, it seems that release management would prefer if we didn't ship this regression in a release version of Firefox.

Hence I've updated the patch to simply remove the *-appearance: none rules from the CSS, which is a very simple solution that also works well.
(I was initially a bit reluctant to do that, since it seems slightly wrong conceptually. However I think that it's better to take an easy fix, rather than letting this issue linger on.)

/botio-windows preview

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/45cbc445c03eba1/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://107.22.172.223:8877/45cbc445c03eba1/output.txt

Total script time: 0.88 mins

Published

• Viewer: http://107.22.172.223:8877/45cbc445c03eba1/web/viewer.html
• B2G Viewer: http://107.22.172.223:8877/45cbc445c03eba1/extensions/b2g/content/web/viewer.html
• Extension: http://107.22.172.223:8877/45cbc445c03eba1/extensions/firefox/pdf.js.xpi
• Extension (AMO): http://107.22.172.223:8877/45cbc445c03eba1/extensions/firefox/pdf.js.amo.xpi

[yurydelendik]

Thank you. We probably shall uplift this change as well.

[Snuffleupagus]

We probably shall uplift this change as well.

Are we going to do another PDF.js uplift to mozilla-central before the next merge day?

During the holidays I've finally had time to setup the build environment for Firefox, and I've also managed to build Firefox successfully :-)
Apart from mozilla-central, I also checked out aurora/beta, so I can try to create the uplift patches. However before attempting to do so, I wanted to know if I also need to create a patch for mozilla-central or if that will be handled by a regular PDF.js uplift?

[yurydelendik]

Regular PDF.js uplift first. We need to do it ourself or to ping ryanvm. I think we already have one pending for older version - we can just ask to update this. We can uplift entire pdf.js for early Aurora.

I think uplifting to beta is tricky at this point anyway. If you want to try -- create patch to beta tree I'll review and will try convince qa to accept it, since they need it badly. :)