[GENERIC viewer] Fix the background color of the findInput when the search term is not found #5465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…earch term is not found When a search term isn't found, the background color of the findInput is supposed to change (to red). This is currently not working as intended, because the CSS rule is not being applied correctly. (It seems that this broke in PR 2208.) This patch also changes the background color to match the one used in the native Firefox findbar, since the old color seemed a bit too pink.
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/bb8c8eb0d4a88e0/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/bb8c8eb0d4a88e0/output.txt Total script time: 1.00 mins Published
|
|
@timvandermeij Do you have time to review this? (If not, just unassign yourself ;-) |
timvandermeij
added a commit
that referenced
this pull request
Nov 18, 2014
[GENERIC viewer] Fix the background color of the findInput when the search term is not found
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a search term isn't found, the background color of the findInput is supposed to change (to red). This is currently not working as intended, because the CSS rule is not being applied correctly. (It seems that this broke in PR #2208.)
This patch also changes the background color to match the one used in the native Firefox findbar, since the old color seemed a bit too pink.