Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Range Support for Chrome 39+40 (#5512) #5598

Merged
merged 1 commit into from
Apr 30, 2015

Conversation

CodingFabian
Copy link
Contributor

Disabling Range Support for Chrome 39 and above, due to regression in
Chromium. Will be enabled once a fix version is confirmed.

@Rob--W
Copy link
Member

Rob--W commented Dec 30, 2014

As I said at #5512 (comment), disabling range requests has a huge impact on perceived performance, so disabling range requests should be the last course of action.

Fortunately, there is a way to resolve the issue without disabling range requests: #5603. Hence I suggest to close this PR in favor of #5603.

@yurydelendik
Copy link
Contributor

Let's see when it will be fixes, and when the fixes reaches the release version of Chrome we replace #5603 with this fix.

@CodingFabian
Copy link
Contributor Author

just to keep on the top of this.
in https://code.google.com/p/chromium/issues/detail?id=442318 it is confirmed that this is broken in chrome 39 and 40. Fix will be going to 41. So we might consider using my patch and disable range requests for those two versions.

@Rob--W
Copy link
Member

Rob--W commented Jan 21, 2015

web/compatibility.js is not loaded in the Chrome extension, so please wait at least two release cycles before merging (and reverting https://github.com/mozilla/pdf.js/pull/5603/files).

I've sent a mail last week to the CWS, and requested information about the browser version usage stats in order to determine when it is safe to drop support for a certain Chrome version, but I have yet to hear back from them. Until that happens, I want to be conservative in dropping features that may affect users of the Chrome extension.

@timvandermeij
Copy link
Contributor

The upstream bug appears to be fixed and it has been a couple of months, so is there anything left to be done here?

@Rob--W
Copy link
Member

Rob--W commented Apr 29, 2015

The Chrome bug only exists in 39 and 40, so this PR should be amended, e.g. by changing the isChromeWithRangeBug declaration to

// Range requests are broken in Chrome 39 and 40, https://crbug.com/442318
var isChromeWithRangeBug = /Chrome\/(39|40)\./.test(navigator.userAgent);

#5603 can be reverted together with this change.

Or we can ignore the backcompat code, since most Chrome users are supposedly using the latest stable version due to auto-update (in contrast to old Android, which doesn't get auto-updated). Then I will revert #5603 as a part of a patch that removes backcompat code from the Chrome extension.

Disabling Range Support for Chrome 39 and 40, due to regression in
Chromium. https://crbug.com/442318
@CodingFabian CodingFabian force-pushed the chrome39-range-disable branch from d77b5ed to 1d4758d Compare April 29, 2015 21:26
@CodingFabian
Copy link
Contributor Author

I have amended this pr. I would propose to merge it and revert #5603

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/15bbf57b077e3fe/output.txt

@timvandermeij
Copy link
Contributor

Fixes #5512.

@timvandermeij timvandermeij changed the title Disable Range Support for Chrome 39+ (#5512) Disable Range Support for Chrome 39+40 (#5512) Apr 30, 2015
timvandermeij added a commit that referenced this pull request Apr 30, 2015
@timvandermeij timvandermeij merged commit 12be47c into mozilla:master Apr 30, 2015
@timvandermeij
Copy link
Contributor

Looks good, thank you! I'll follow this up with reverting #5603.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants