-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Range Support for Chrome 39+40 (#5512) #5598
Disable Range Support for Chrome 39+40 (#5512) #5598
Conversation
As I said at #5512 (comment), disabling range requests has a huge impact on perceived performance, so disabling range requests should be the last course of action. Fortunately, there is a way to resolve the issue without disabling range requests: #5603. Hence I suggest to close this PR in favor of #5603. |
Let's see when it will be fixes, and when the fixes reaches the release version of Chrome we replace #5603 with this fix. |
just to keep on the top of this. |
I've sent a mail last week to the CWS, and requested information about the browser version usage stats in order to determine when it is safe to drop support for a certain Chrome version, but I have yet to hear back from them. Until that happens, I want to be conservative in dropping features that may affect users of the Chrome extension. |
The upstream bug appears to be fixed and it has been a couple of months, so is there anything left to be done here? |
The Chrome bug only exists in 39 and 40, so this PR should be amended, e.g. by changing the // Range requests are broken in Chrome 39 and 40, https://crbug.com/442318
var isChromeWithRangeBug = /Chrome\/(39|40)\./.test(navigator.userAgent); #5603 can be reverted together with this change. Or we can ignore the backcompat code, since most Chrome users are supposedly using the latest stable version due to auto-update (in contrast to old Android, which doesn't get auto-updated). Then I will revert #5603 as a part of a patch that removes backcompat code from the Chrome extension. |
Disabling Range Support for Chrome 39 and 40, due to regression in Chromium. https://crbug.com/442318
d77b5ed
to
1d4758d
Compare
I have amended this pr. I would propose to merge it and revert #5603 |
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/15bbf57b077e3fe/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/15bbf57b077e3fe/output.txt Total script time: 0.82 mins Published |
Fixes #5512. |
Disable Range Support for Chrome 39+40 (#5512)
Looks good, thank you! I'll follow this up with reverting #5603. |
Disabling Range Support for Chrome 39 and above, due to regression in
Chromium. Will be enabled once a fix version is confirmed.