Use the |shadow| function from src/shared/util.js in viewer.js #5691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/d0defa6dfdc54d8/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/d0defa6dfdc54d8/output.txt Total script time: 0.80 mins Published |
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/237382532190ca9/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/b97dfb58847da7d/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/b97dfb58847da7d/output.txt Total script time: 17.56 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/237382532190ca9/output.txt Total script time: 23.04 mins
|
timvandermeij
added a commit
that referenced
this pull request
Feb 2, 2015
Use the |shadow| function from src/shared/util.js in viewer.js
|
Nice work! |
speedplane
pushed a commit
to speedplane/pdf.js
that referenced
this pull request
Feb 24, 2015
Use the |shadow| function from src/shared/util.js in viewer.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on refactoring the
PresentationModecode, I noticed that in viewer.js we currently repeat the same "shadowing" code six times. Since this is a verbatim copy of https://github.com/mozilla/pdf.js/blob/master/src/shared/util.js#L321, I think it makes sense to just use that function instead.