-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only skip the |!isSymbolicFont| check for TrueType (3, 1) cmap tables if no previous cmap table was found (PR 5703 followup) #5743
Conversation
… if no previous cmap table was found (PR 5703 followup) Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=894572.
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/3777895575fecee/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/404aaa1a3e028c0/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/3777895575fecee/output.txt Total script time: 17.30 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/404aaa1a3e028c0/output.txt Total script time: 23.08 mins
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/5053b78204d9a03/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/5053b78204d9a03/output.txt Total script time: 0.78 mins Published |
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://107.22.172.223:8877/72e80e4f1beee84/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://107.21.233.14:8877/eb2433c87fa5f8c/output.txt |
Only skip the |!isSymbolicFont| check for TrueType (3, 1) cmap tables if no previous cmap table was found (PR 5703 followup)
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/72e80e4f1beee84/output.txt Total script time: 19.20 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/eb2433c87fa5f8c/output.txt Total script time: 22.88 mins
|
Only skip the |!isSymbolicFont| check for TrueType (3, 1) cmap tables if no previous cmap table was found (PR 5703 followup)
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=894572.
I just found that PR #5703 unfortunately caused a regression, which this patch fixes. Sorry about that!
Although I'm actually putting most of the blame for that on our lack of test coverage :-)