Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guess CIDFontType0 subtype based on font file contents (issue 5751) #5756

Merged
merged 1 commit into from
Apr 24, 2015
Merged

Guess CIDFontType0 subtype based on font file contents (issue 5751) #5756

merged 1 commit into from
Apr 24, 2015

Conversation

Snuffleupagus
Copy link
Collaborator

This patch is inspired by PR #4671.

Fixes #5751.
Fixes #4293.

The problem with the PDF file in the issue, is that it claims the font is CIDFontType0 instead of the correct CIDFontType0C.
The most logical solution would be to check if the font has a CFF file, but since the header of those begins with a version number, that seemed complicated in general.
In contrast Type1 fonts have a much simpler structure, see http://partners.adobe.com/public/developer/en/font/T1_SPEC.PDF#page=18, hence adding a isType1file function seemed easiest.

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/9665519e45b68d7/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/63ea7017168d748/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/9665519e45b68d7/output.txt

Total script time: 17.29 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/63ea7017168d748/output.txt

Total script time: 22.23 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@brendandahl
Copy link
Contributor

/botio makeref

Good to merge when makeref passes ...

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://107.21.233.14:8877/e93b3fade8b7ec3/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://107.22.172.223:8877/e1e6cda0e8f0894/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/e1e6cda0e8f0894/output.txt

Total script time: 20.43 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/e93b3fade8b7ec3/output.txt

Total script time: 23.33 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

timvandermeij added a commit that referenced this pull request Apr 24, 2015
Guess CIDFontType0 subtype based on font file contents (issue 5751)
@timvandermeij timvandermeij merged commit 48b2f6d into mozilla:master Apr 24, 2015
@Snuffleupagus Snuffleupagus deleted the issue-5751 branch April 25, 2015 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDF renders with severe issues Font not rendered correctly
4 participants