Add an extra set of // to the comment for the URL polyfill, since the preprocessor eats one set, thus breaking the world (PR 6846 followup)
#6873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he preprocessor eats one set, thus breaking the world (PR 6846 followup) The Firefox addon currently fails with: ``` SyntaxError: missing ; before statement pdf.js:1692:12 TypeError: PDFJS.shadow is not a function viewer.js:6228:12 ```
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/46142629e6a3caa/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/46142629e6a3caa/output.txt Total script time: 0.91 mins Published |
timvandermeij
added a commit
that referenced
this pull request
Jan 14, 2016
Add an extra set of `//` to the comment for the URL polyfill, since the preprocessor eats one set, thus breaking the world (PR 6846 followup)
|
I can confirm that this fixes the issue. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Firefox addon currently fails with:
Re: PR #6846 (see e.g. mozilla/pdfjs-dist@1a15d54#diff-eccf5b94e31b0939738de07167e02af6R11113).