Support syncing of settings in Chrome extension #7346
Merged
+91
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
chrome.storage.sync
to store preferences instead ofchrome.storage.local
, to allow settings to be synchronized if the user chooses to sign in in Chrome and enables synchronization of extension preferences.Tested with Chrome 50 as follows:
node make chromium
).storageAreaName = 'local'; storageArea = chrome.storage.local;
location.reload()
from the console).With the above steps, you can verify that the migration logic works as intended. Now, also test whether the preferences are actually applied:
Fixes #7325.
/cc @timvandermeij Please review this PR.