Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert the files in the /src/core folder to ES6 modules #8284

Merged
merged 2 commits into from
May 30, 2017
Merged

Convert the files in the /src/core folder to ES6 modules #8284

merged 2 commits into from
May 30, 2017

Conversation

Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Apr 13, 2017 •
edited
Loading

Depends on PR #8364.

Please note that the glyphlist.js and unicode.js files are converted to CommonJS modules instead, since Babel cannot handle files that large and they are thus excluded from transpilation.

Much smaller diff with https://github.com/mozilla/pdf.js/pull/8284/files?w=1.

@yurydelendik
Copy link
Contributor

Sorry, I did not catch this before but we need to use cjs paths e.g. '../shared/util.js'

@yurydelendik
Copy link
Contributor

Blocked by #8285

@Snuffleupagus Snuffleupagus mentioned this pull request May 2, 2017
Merged
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2017

From: Bot.io (Linux)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 1

Live output at: http://107.21.233.14:8877/fe40cd1ec8399f2/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2017

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.215.176.217:8877/2206567eabe3a40/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2017

From: Bot.io (Linux)

Failed

Full output at http://107.21.233.14:8877/fe40cd1ec8399f2/output.txt

Total script time: 36.05 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/fe40cd1ec8399f2/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2017

From: Bot.io (Windows)

Success

Full output at http://54.215.176.217:8877/2206567eabe3a40/output.txt

Total script time: 26.32 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

yurydelendik
yurydelendik approved these changes May 3, 2017
View reviewed changes
Copy link
Contributor

@yurydelendik yurydelendik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with fixing export section formatting at src/core/cff_parser.js

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2017

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/092fa91615c6ce1/output.txt

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux test

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2017

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/bf0c5d36357d6b8/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2017

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/bf0c5d36357d6b8/output.txt

Total script time: 17.77 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/bf0c5d36357d6b8/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2017

From: Bot.io (Windows)

Success

Full output at http://54.215.176.217:8877/092fa91615c6ce1/output.txt

Total script time: 26.47 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux test

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2017

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/8d588061e58ca34/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2017

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/8d588061e58ca34/output.txt

Total script time: 17.68 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/8d588061e58ca34/reftest-analyzer.html#web=eq.log

@yurydelendik
Copy link
Contributor

/botio-linux test

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2017

From: Bot.io (Linux m4)

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://54.67.70.0:8877/d561acb476d7a76/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2017

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/d561acb476d7a76/output.txt

Total script time: 17.72 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/d561acb476d7a76/reftest-analyzer.html#web=eq.log

@yurydelendik
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2017

From: Bot.io (Windows)

Received

Command cmd_test from @yurydelendik received. Current queue size: 1

Live output at: http://54.215.176.217:8877/39ac640e760ea08/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2017

From: Bot.io (Windows)

Success

Full output at http://54.215.176.217:8877/39ac640e760ea08/output.txt

Total script time: 26.44 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2017

From: Bot.io (Linux m4)

Received

Command cmd_test from @yurydelendik received. Current queue size: 1

Live output at: http://54.67.70.0:8877/f6a7ee2033f096d/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 3, 2017

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/f6a7ee2033f096d/output.txt

Total script time: 19.04 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/f6a7ee2033f096d/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus mentioned this pull request May 20, 2017
Merged
@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/3be71061bf6acc1/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/3be71061bf6acc1/output.txt

Total script time: 18.65 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/3be71061bf6acc1/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/0811517aa2646b9/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/0811517aa2646b9/output.txt

Total script time: 21.09 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/0811517aa2646b9/reftest-analyzer.html#web=eq.log

@yurydelendik
Copy link
Contributor

/botio-linux test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://54.67.70.0:8877/7726f778ca04d00/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/7726f778ca04d00/output.txt

Total script time: 22.02 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/7726f778ca04d00/reftest-analyzer.html#web=eq.log

yurydelendik and others added 2 commits May 30, 2017 22:06
@yurydelendik @Snuffleupagus
Using pre-built code for testing.
b66b705
@Snuffleupagus
Convert the files in the /src/core folder to ES6 modules
982b6aa 
Please note that the `glyphlist.js` and `unicode.js` files are converted to CommonJS modules instead, since Babel cannot handle files that large and they are thus excluded from transpilation.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/f26d1fe17173f2f/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/c175bd1cfb1defe/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/f26d1fe17173f2f/output.txt

Total script time: 17.50 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.215.176.217:8877/fba8be581985230/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/1f8aae4b60591dd/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Success

Full output at http://54.215.176.217:8877/c175bd1cfb1defe/output.txt

Total script time: 29.60 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/1f8aae4b60591dd/output.txt

Total script time: 17.48 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@Snuffleupagus
Copy link
Collaborator Author

Since Travis seem to be having problems, let's run linting once more just to check that there's no issue.

/botio-linux lint

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_lint from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/8d63156b997798a/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/8d63156b997798a/output.txt

Total script time: 0.97 mins

  • Lint: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)

Success

Full output at http://54.215.176.217:8877/fba8be581985230/output.txt

Total script time: 29.39 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@Snuffleupagus Snuffleupagus merged commit e517187 into mozilla:master May 30, 2017
@Snuffleupagus Snuffleupagus mentioned this pull request May 30, 2017
Closed
@Snuffleupagus Snuffleupagus deleted the es6-modules-src branch May 30, 2017 21:21
@timvandermeij
Copy link
Contributor

Hooray! 💥

movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
@Snuffleupagus
Merge pull request mozilla#8284 from Snuffleupagus/es6-modules-src
ff6c369 
Convert the files in the `/src/core` folder to ES6 modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurydelendik yurydelendik yurydelendik approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Snuffleupagus @yurydelendik @pdfjsbot @timvandermeij