Adds gulp dist-install command; using pdfjs-dist package in examples. #8401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurydelendik
force-pushed
the
dist-install
branch
from
43dc75a to
c80ef4b
Compare
README.md
Outdated
| @@ -106,6 +106,8 @@ The repository contains a hello world example that you can run locally: | |||
|
|
|||
| + [examples/helloworld/](https://github.com/mozilla/pdf.js/blob/master/examples/helloworld/) | |||
|
|
|||
| More examples can be found at the examples folder. Some of them are using the pdfjs-dist package, which can be built and installed in this repo direcotry via `gulp dist-install` command. | |||
There was a problem hiding this comment.
Nit: direcotry should be directory
|
Could you update this patch to resolve the conflict? |
yurydelendik
force-pushed
the
dist-install
branch
from
c80ef4b to
e1fc82d
Compare
timvandermeij
requested changes
Jun 11, 2017
examples/learning/helloworld.html
Outdated
|
|
||
| <script src="../../build/generic/build/pdf.js"></script> | ||
| <script src="../../node_modules/pdfjs-dist/pdf.js"></script> |
There was a problem hiding this comment.
I think this should end with /build/pdf.js instead. Now it throws ReferenceError: PDFJS is not defined.
There was a problem hiding this comment.
Fixed, thanks.
yurydelendik
force-pushed
the
dist-install
branch
from
e1fc82d to
a18caa7
Compare
timvandermeij
approved these changes
Jun 12, 2017
|
Looks good. Thank you for fixing this! |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
Adds gulp dist-install command; using pdfjs-dist package in examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will simplify example usage (e.g. now examples can be copied and used as is in the custom project that has pdfjs-dist installed) and avoid git-tag error when
gulp distrun.