Fix the remaining cases of inconsistent spacing and trailing commas in objects, and enable the comma-dangle and object-curly-spacing ESLint rules
#8478
Conversation
|
/botio-linux preview |
|
/botio test |
…n objects, and enable the `comma-dangle` and `object-curly-spacing` ESLint rules http://eslint.org/docs/rules/comma-dangle http://eslint.org/docs/rules/object-curly-spacing *Please note:* This patch was created automatically, using the ESLint `--fix` command line option. In a couple of places this caused lines to become too long, and I've fixed those manually; please refer to the interdiff below for the only hand-edits in this patch. ```diff diff --git a/gulpfile.js b/gulpfile.js index d18b9c58..7d47fd8d 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -1247,7 +1247,8 @@ gulp.task('gh-pages-git', ['gh-pages-prepare', 'wintersmith'], function () { var reason = process.env['PDFJS_UPDATE_REASON']; safeSpawnSync('git', ['init'], { cwd: GH_PAGES_DIR, }); - safeSpawnSync('git', ['remote', 'add', 'origin', REPO], { cwd: GH_PAGES_DIR, }); + safeSpawnSync('git', ['remote', 'add', 'origin', REPO], + { cwd: GH_PAGES_DIR, }); safeSpawnSync('git', ['add', '-A'], { cwd: GH_PAGES_DIR, }); safeSpawnSync('git', [ 'commit', '-am', 'gh-pages site created via gulpfile.js script', ```
|
@timvandermeij Thank you so much for reviewing and merging all the prior PRs that blocked this one! :-) |
|
/botio-linux lint |
From: Bot.io (Linux m4)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/66a22c858c6b14b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/66a22c858c6b14b/output.txt Total script time: 1.01 mins
|
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/79afd034502c2e9/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 2 Live output at: http://54.215.176.217:8877/7eaa48283c4e7ea/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/79afd034502c2e9/output.txt Total script time: 17.02 mins
Image differences available at: http://54.67.70.0:8877/79afd034502c2e9/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/7eaa48283c4e7ea/output.txt Total script time: 29.79 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/4fdf7e34f9ab64d/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/4fdf7e34f9ab64d/output.txt Total script time: 2.20 mins Published |
|
/botio-linux makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/abb1c1d4e65172f/output.txt |
|
Nice work on standardization! I'm happy that this is enforced using ESLint now instead of having to add this manually in reviews. |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/abb1c1d4e65172f/output.txt Total script time: 16.07 mins
|
Fix the remaining cases of inconsistent spacing and trailing commas in objects, and enable the `comma-dangle` and `object-curly-spacing` ESLint rules
http://eslint.org/docs/rules/comma-dangle
http://eslint.org/docs/rules/object-curly-spacing
Please note: This patch was created automatically, using the ESLint
--fixcommand line option. In a couple of places this caused lines to become too long, and I've fixed those manually; please refer to the interdiff below for the only hand-edits in this patch.